1

I'm aware I could tell which wallet address is calling the contract and whitelist certain addresses. But how could I instead make a contract that can only be used by people who hold a certain secret key? I was thinking of a standard hashed password mechanism but with something to protect against replay attacks, since everything on-chain is publicly visible. Searching around, I found this article using that for a secrets store, and here's the code.

  1. I generate a secret and pass it out.
  2. User hashes their secret with a nonce the contract stores.
  3. User calls contract method with the hash and whatever other params.
  4. Contract increments nonce so the hash can't be reused.

But what happens if the method call fails? Won't everyone (or at least some node operators) see the failed call with its params and be able to reuse the hash from it, since the contract's nonce never got incremented?

Edit: Oh, the caller could just include the wallet address in the hash so nobody else can use that hash. Though I'm still curious about whether or not there's a vulnerability in the original solution.

0

2 Answers 2

1

Yes, the original solution is unsafe. Cross checking the sender address of the hash is really important. Infact, the recent Wormhole Hack on a Solana contract was caused due to a vulnerability closely related to what you described.

1
  • Yikes, hopefully the author of the Medium article I linked sees my comment warning him about this.
    – sudo
    Feb 6 at 6:59
1

You might want to have a look at the solution used in the Multisig contract supported by tezos-client. It is documented here.

In essence:

2
  • Wow, surprised I missed that CHECK_SIGNATURE instruction. Better than trying to do this with hashes only.
    – sudo
    Feb 7 at 6:28
  • Oh and thanks for mentioning SELF_ADDDRESS and CHAIN_ID; I hadn't thought to include those.
    – sudo
    Feb 12 at 19:46

Your Answer

By clicking “Post Your Answer”, you agree to our terms of service, privacy policy and cookie policy

Not the answer you're looking for? Browse other questions tagged or ask your own question.